Closed randytpierce closed 7 months ago
Package | Line Rate | Branch Rate | Health |
---|---|---|---|
vxingest | 33% | 42% | ❌ |
vxingest.builder_common | 29% | 17% | ❌ |
vxingest.ctc_to_cb | 12% | 1% | ❌ |
vxingest.grib2_to_cb | 12% | 1% | ❌ |
vxingest.netcdf_to_cb | 13% | 1% | ❌ |
vxingest.partial_sums_to_cb | 12% | 1% | ❌ |
vxingest.utilities | 30% | 32% | ❌ |
Summary | 16% (488 / 3017) | 6% (40 / 700) | ❌ |
Looks good. Is there an easy way to add to the tests to make sure we don't have a regression?
I have been thinking about that, but it isn't really easy. It requires modifying an actual station entry in the database. I might be able to add a fake station. I have done that kind of thing before. I think we should defer it for now, though. randy
On Fri, Feb 2, 2024 at 1:44 PM Ian McGinnis @.***> wrote:
Looks good. Is there an easy way to add to the tests to make sure we don't have a regression?
— Reply to this email directly, view it on GitHub https://github.com/NOAA-GSL/VxIngest/pull/317#issuecomment-1924670649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDVQPUSPCYSAOS5WYQQV6LYRVFY5AVCNFSM6AAAAABCXDYGL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGY3TANRUHE . You are receiving this because you were assigned.Message ID: @.***>
-- Randy Pierce
Errors were being logged when a station had missing wind components. The station with missing wind components should be gracefully ignored.