Closed dependabot[bot] closed 7 months ago
@randytpierce - if you wouldn't mind giving this a quick once-over, I'd appreciate it! The Ruff upgrade (docs here) come with some updated linter rules that I went ahead and added fixes for. Basically, we switched:
some_dict[some_key] = some_dict[some_key] if some_key in some_dict else {}
to use Python's dict.get()
method.
some_dict[some_key] = some_dict.get(some_key, {})
If a default isn't specified and dict.get()
doesn't find a value it returns None
, so I've updated a part of the code that has that in the default to make it implicit.
Package | Line Rate | Branch Rate | Health |
---|---|---|---|
vxingest | 33% | 42% | ❌ |
vxingest.builder_common | 29% | 17% | ❌ |
vxingest.ctc_to_cb | 12% | 1% | ❌ |
vxingest.grib2_to_cb | 12% | 1% | ❌ |
vxingest.netcdf_to_cb | 13% | 1% | ❌ |
vxingest.partial_sums_to_cb | 12% | 1% | ❌ |
vxingest.utilities | 30% | 32% | ❌ |
Summary | 16% (488 / 3017) | 6% (40 / 700) | ❌ |
sure! randy
On Mon, Feb 5, 2024 at 10:40 AM Ian McGinnis @.***> wrote:
@randytpierce https://github.com/randytpierce - if you wouldn't mind giving this a quick once-over, I'd appreciate it! The Ruff upgrade come with some updated linter rules that I went ahead and added fixes for.
— Reply to this email directly, view it on GitHub https://github.com/NOAA-GSL/VxIngest/pull/318#issuecomment-1927569095, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDVQPWSFYJOM3EMRAJYG3TYSEKQ3AVCNFSM6AAAAABCZIULMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGU3DSMBZGU . You are receiving this because you were mentioned.Message ID: @.***>
-- Randy Pierce
Thanks! I redid the Dockerfile a while back after Couchbase fixed their Python package so now we're directly using their pre-built binary wheels. You can see that part here: https://github.com/NOAA-GSL/VxIngest/blob/89ba79d61f5cde71fc0cd9f72add469715b5520c/docker/ingest/Dockerfile#L53-L55
Building eccodes
for cfgrib
is a different story, but I have some caching setup for that so we don't have a lot of build time there.
Bumps the python-dependencies group with 2 updates: couchbase and ruff.
Updates
couchbase
from 4.1.10 to 4.1.11Commits
7b762ee
Update C++ core to 1.0.0-dp.12aa599ba
PYCBC-1548: Support Vector Searchd320ea2
When getting the error context handle the case where the exception does not c...a1161ae
PYCBC-1549: Support for maxTTL value of -1 for collection 'no expiry'57d93dc
Add missing exception types to ExceptionMapUpdates
ruff
from 0.1.14 to 0.2.0Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
1fadefa
Bump version to 0.2.0 (#9762)06ad687
Deduplicate deprecation warnings for v0.2.0 release (#9764)148b64e
Fix issue where output format mode would not change tofull
if preview mode...99eddbd
Remove stale preview documentation from stabilized rule behaviors (#9759)836d2ea
Restore RUF011 documentation (#9758)994514d
RedirectPHG001
toS307
andPGH002
toG010
(#9756)a578414
RedirectTRY200
toB904
(#9755)0d752e5
Add tests for redirected rules (#9754)46c0937
Use fake rules for testing deprecation and removal infrastructure (#9752)e5008ca
Fix bug where selection included deprecated rules during preview (#9746)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show