search

NOAA-GSL / pygraf

ADB's Python graphics package
MIT License
10 stars 11 forks source link

correction to firewx to properly use soil moisture #123

Closed cshartsough closed 2 years ago

cshartsough commented 2 years ago

This change is to use soilw rather than soilm in the Hourly Wildfire Potential (firewx) calculation. The current code also had an error, rteating the input as a percentage rather than a fraction.

passed pylint. will check pytest in GitHub.

Before and after for RRFS test (Eric James reviewed): firewx_full_sfc_f002_before firewx_full_sfc_f002_after

cshartsough commented 2 years ago

"before" pic was overwritten by the "after". here's the initial "before"

Screen Shot 2021-10-06 at 3 49 24 PM
christinaholtNOAA commented 2 years ago

Was there a unit change at all?

cshartsough commented 2 years ago

Was there a unit change at all?

Good question. No, the final value for "mois" is a fraction in both cases.