This merge introduces a number of changes and refactorings
Add goleak to our integration test suite to check for leaking goroutines.
Refactor the director.ExtractKeys function to getMapKeys for clarity
Refactor the manager to eliminate global variables and to make standalone functions full struct members
Refactor the director to eliminate global variables and to make standalone functions full struct members
Add a .Close() cleanup member function to the manager and director that closes out database connections
Add a call to clean up idle HTTP connections in the client pkg
This has the effect of dropping the number of dangling goroutines from the 100's to zero in most cases. However, there is one occasional flaky goroutine that appears with the client package. We'll want to address that in the future so our test suite doesn't have test flakes.
This merge introduces a number of changes and refactorings
director.ExtractKeysfunction togetMapKeysfor claritymanagerto eliminate global variables and to make standalone functions full struct membersdirectorto eliminate global variables and to make standalone functions full struct members.Close()cleanup member function to themanageranddirectorthat closes out database connectionsThis has the effect of dropping the number of dangling goroutines from the 100's to zero in most cases. However, there is one occasional flaky goroutine that appears with the
clientpackage. We'll want to address that in the future so our test suite doesn't have test flakes.