NOAA-MDL / GIFTs

Generate IWXXM From TAC software
Other
11 stars 2 forks source link

Internal bulletin identifier incorrect when WMO AHL line is inserted into output. #33

Closed mgoberfield closed 2 years ago

mgoberfield commented 2 years ago

According to Section 4.1.4 of the Guidelines for the Implementation of OPMET Data Exchange using IWXXM 4th Edition, the only allowable file extension for XML products are 'xml' and 'xml.gz', as the bulletinIdentifier text.

To facilitate the ease of transmitting the XML products by US OPMET Gateway's current practice, an option was provided to the bulletin.write() method to insert the WMO AHL as the first line in the resulting output file. The bug is that the text for bulletinIdentifier is either 'txt' or 'txt.gz' as file extensions when this option is used. This is contrary to the Guidelines.

mgoberfield commented 2 years ago

Fixed with commit https://github.com/NOAA-MDL/GIFTs/commit/211970ec2fedfeea5e53dab147a3f595af916a62