Seek bugfix reverted - Githubissues

NOAA-MDL / grib2io

Python interface to the NCEP G2C Library for reading and writing GRIB2 messages.

https://noaa-mdl.github.io/grib2io

MIT License

30 stars 11 forks source link

Seek bugfix reverted #50

Closed zflamig closed 1 year ago

zflamig commented 1 year ago

Looks like the bugfix to seek was reverted in the xarray PR: https://github.com/NOAA-MDL/grib2io/blob/master/grib2io/_grib2io.py#L418

EricEngle-NOAA commented 1 year ago

Thanks for reporting! Are you having issues when performing seek(1)?

zflamig commented 1 year ago

Correct. Seek(1) crashes

EricEngle-NOAA commented 1 year ago

@zflamig we have this fixed in the branch where we are working on a large refactoring for v2.0. For v2.0, we are allowing a 0th message (see #51). There will 2 methods to reading GRIB2 messages from a file:

file-like IO using read(), seek(), and tell()
random-access IO using indexing on the file object

Both of these exist now, but will be cleaned up for v2.0

EricEngle-NOAA commented 1 year ago

@zflamig OK with you to close this?