search

NOAA-OCM / SWMPrExtension

Functions for Analyzing and Plotting SWMP Estuary Monitoring Data from the NERR System archive at
http://cdmo.baruch.sc.edu/
Other
12 stars 5 forks source link

Update sk_seasonal #31

Closed padilla410 closed 6 years ago

padilla410 commented 6 years ago

Update sk_seasonal to remove dependence on EnvStats.

This will involve updates to the sk_seasonal function and the sk_tidy function.

fawda123 commented 6 years ago

Hey Julie, I just had to do the same for my WRTDStidal package. I thought this might be helpful for SWMPrExtension:

Seasonal Kendall tests: https://github.com/fawda123/WRTDStidal/blob/master/R/kendallSeasonalTrendTest.R

Regular Kendall: https://github.com/fawda123/WRTDStidal/blob/master/R/kendallTrendTest.R

It should do the trick if you just copy these files into your R folder. You'll have to update the examples in each file with something relevant for your package and of course update your DESCRIPTION file to remove the EnvStats dependency.

Hope it helps.

-Marcus

fawda123 commented 6 years ago

Ugh, nevermind, sounds like EnvStats will still be on CRAN.

padilla410 commented 6 years ago

(1) You are a total hero.

(2) Where did you hear about EnvStats remaining on CRAN? I emailed the developer but never heard back.

padilla410 commented 6 years ago

...and I just opened up my work email. Happy to see this package has a new maintainer.

Note that Alexander Kowarik alexander.kowarik@statistik.gv.at took over maintainership of EnvStats and successfully submitted to CRAN.

Best, Uwe Ligges

swmpkim commented 6 years ago

EnvStats was going to be taken off of CRAN? It's such a great package; that would be tragic! Really glad it's got a new maintainer!

fawda123 commented 6 years ago

Yea I'm really glad it's not going away, I'm just a little salty that I wasted the time to remove the dependency.

swmpkim commented 6 years ago

So the lesson here is.... don't be so on top of things next time? ;-) I hope it wasn't too much time that you lost to it!