NOAA-ORR-ERD / PyGnome

The General NOAA Operational Modeling Environment
https://gnome.orr.noaa.gov/doc/pygnome/index.html
Other
59 stars 44 forks source link

PyGnome python setup.py develop/install fails with link issue #112

Open bhlevca opened 2 years ago

bhlevca commented 2 years ago

PyGnome cannot find cy_basic_types.cp310-win_amd64.lib because it looks for it in the wrong place:

LINK : fatal error LNK1181: cannot open input file 'build\temp.win-amd64-3.10\Release\gnome\cy_gnome\cy_basic_types.cp310-win_amd64.lib

in fact the library is built in: /PyGnome/py_gnome/build/temp.win-amd64-3.10/lib_gnome

I copied them manually and managed to build PyGnome properly.

It is probably necessary to fix setyp.py to point to the right directory for cy_basic_types.cp-.lib so that link does not fail.

jay-hennen commented 2 years ago

What version of setuptools are you using, and have you pulled the lastest changes on master?

We updated the setup.py on master about three weeks ago to rectify this exact issue.

bhlevca commented 2 years ago

I am using a fork from DHI, but they use your setup.py unmodified. Hence, I thought of notifying you as well. I am going to tell them to update from master

hawklorry commented 2 years ago

What version of setuptools are you using, and have you pulled the lastest changes on master?

We updated the setup.py on master about three weeks ago to rectify this exact issue.

Could you please also update the develop branch of WebGnomeAPI and WebGnomeClient to work with the latest Pynome? Thanks.