NOAA-ORR-ERD / WebGnomeClient

Javascript client that uses the WebGnomeAPI to create and run py_gnome models.
3 stars 9 forks source link

Error with federated-analytics with `yarn install` #19

Open ChrisBarker-NOAA opened 1 year ago

ChrisBarker-NOAA commented 1 year ago

A user reported:

at the stage of installing WebGnomeClient when I ran the command "yarn install", I got the error below:

error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads https://FA_Token:N3zVYtF5k-EfVi5zNvvU@gitlab.orr.noaa.gov/erd/federated-analytics.git
Directory: /home/pasa/WebGnomeClient
Output:
fatal: unable to access 'https://gitlab.orr.noaa.gov/erd/federated-analytics.git/': SSL connection timeout
ChrisBarker-NOAA commented 1 year ago

federated-analytics is a google service we use to capture statistics about how our applications are used.

It may not be accessible from outside a US gov't network, or outside the US, or ???

Solution:

First we need to remove federated-analytics from package.json. It is listed on line 20 I believe, and I think json does not support comments, so you need to just get rid of the line. After that, yarn install should work.

[Side note: the JSON spec does not support comments, but some implementations do -- it might be worth commenting that out with \\ and see if it works]

As for the client's runtime, I think it should run without any changes.

Google analytics (and federated analytics), as far as I know, are packages setup to run transparently without explicitly being defined or called in the code of the web application itself. So it is referred to in the main page of the app (./index.html, line 12), and nowhere else. And it will either be successfully requested causing the app to run with analytics, or the package request will fail, causing the app to run without analytics.

If it turns out that the missing federated-analytics package is causing problems, we can remove the call to it in ./index.html, line 12

Please give that a try an report back here.

akbarinasab commented 1 year ago

thank you