Open ChrisBarker-NOAA opened 2 months ago
Are you sure this is still correct when we take the sinusoidal shape of the grid into account plus the 'angle' variable? Actually when I look at this again it appears the mistake is actually that vy should be zero. That's how it would appear in a 'normal' sgrid file right?
If you want to put this math in feel free. At the moment the sinusoid file is only used in loading tests; the data within is actually never used. Of course it should still be a 'correct' file!
well, it depends on the goal, but if we want a uniform flow parallel to the sides, it's needs adjustment -- this came up when someone was testing a new interpolation method.
i put in the issue so I wouldn't forget ....
In
gen_analytical_datasets
, there is:def gen_sinusoid(filename=None)
however, it has:
which makes the y -direction velocity constant -- which is almost a sinusoidal flow, but not quite parallell to the chennel.
It should have a constant magnitude, the the y component should also change sinusoidally (out of phase).
Somethign like this: