search

NOAA-OWP / DMOD

Distributed Model on Demand infrastructure for OWP's Model as a Service
Other
7 stars 15 forks source link

`ModelExecRequestClient` removed in #409, but still used in several places #467

Open aaraney opened 1 year ago

aaraney commented 1 year ago

Failure: https://github.com/NOAA-OWP/DMOD/actions/runs/6734518026/job/18306532115?pr=463#step:11:41

Cause:

ModelExecRequestClient was removed in #409. https://github.com/NOAA-OWP/DMOD/pull/409/files#diff-2192a18bf3f6c20ec42a0c4835df7df6da32273f4dba87d44a7c8cffd823d3b6L885

Effected Code:

https://github.com/NOAA-OWP/DMOD/blob/3f41bbb681fe08bab3fa59c9fb7bdd76637fe12e/python/lib/client/dmod/client/request_clients.py#L2

https://github.com/NOAA-OWP/DMOD/blob/3f41bbb681fe08bab3fa59c9fb7bdd76637fe12e/python/lib/client/dmod/client/request_clients.py#L22

https://github.com/NOAA-OWP/DMOD/blob/3f41bbb681fe08bab3fa59c9fb7bdd76637fe12e/python/lib/client/dmod/client/request_clients.py#L39

https://github.com/NOAA-OWP/DMOD/blob/1f2faac423a90c04e74e87ea679c9469a0688d1b/python/gui/MaaS/client.py#L24

https://github.com/NOAA-OWP/DMOD/blob/1f2faac423a90c04e74e87ea679c9469a0688d1b/python/gui/MaaS/cbv/DMODProxy.py#L203

aaraney commented 9 months ago

This looks like it will be resolved by #424.

aaraney commented 6 months ago

reopening. see #579