search

NOAA-OWP / DMOD

Distributed Model on Demand infrastructure for OWP's Model as a Service
Other
7 stars 15 forks source link

Address issues related to `DataTransmitMessage`'s `data` field type and handling of binary data #486

Closed aaraney closed 7 months ago

aaraney commented 8 months ago

The original title for this issue was Change DataTransmitMessage's data field type to accommodate binary data. See discussion here and here.

It relates to #424 and may still have implications on #432.

However, as noted below, we cannot simply change the data field from str to bytes, as this breaks the implementation for serialization. That said, this leaves in question whether/how we can support anything beyond unicode data. This issue should track further discussion and work on addressing this.

robertbartel commented 7 months ago

As noted over in the other issue comments, it looks like this would break JSON serialization for DataTransmitMessage.

aaraney commented 7 months ago

Yeah you are right, @robertbartel. I was not using all of my brain when I was writing this up 😅. There does seem to be a larger issue that we cannot upload binary data without first encoding it in something like base64 or base85, but we should address that in a separate issue.