NOAA-OWP / DMOD

Distributed Model on Demand infrastructure for OWP's Model as a Service
Other
7 stars 15 forks source link

Update DataFormat values and domain detectors to account for hydrofabric contextual restriction #605

Open robertbartel opened 5 months ago

robertbartel commented 5 months ago

For a large portion of all possible DMOD datasets, the data and metadata only become fully meaningful in the context of a particular hydrofabric dataset that establishes the spatial domain. For example, without an associated hydrofabric, an AORC forcing CSV file for catchment cat-112 contains data applicable only to some abstract conceptual region. It cannot be determined whether the data is accurate (i.e., was the regridding correct for cat-112) or valid (i.e., is there a cat-112) outside of the context of a hydrofabric.

The dataset modeling of DMOD, including the data formats, data domains, and data domain detectors, does not fully account for the relationship between these datasets and a hydrofabric dataset. This needs to be corrected.

aaraney commented 5 months ago

This is a great point, @robertbartel. We should talk to the HF team about what assumptions we can make about certain metadata fields in a HF. For example, can we rely on cat-112 as a name without other context (i.e. the HF version, implying that the cat number can change version to version). I think understanding their domain and data model will be really helpful to this task.