NOAA-OWP / DMOD

Distributed Model on Demand infrastructure for OWP's Model as a Service
Other
7 stars 15 forks source link

Deal with Redis license changing #639

Open robertbartel opened 4 months ago

robertbartel commented 4 months ago

As discussed here (and actually executed here), Redis has changed their licensing to no longer be open source in newer versions. Opening this for deliberate tracking of subtasks to ensure DMOD remains functional, open, and license-compliant following this.

One thing worth noting at this level is that, as of this writing, the official Redis Docker image page on Dockerhub does still refer to Redis as being open source. Likely not by accident, the latest version for images is 7.2.5, which is before the licensing change (7.4).

christophertubbs commented 2 months ago

Took a look at Valkey. It should not only be a drop in replacement, but a deployment decision. It's a fork from before Redis decided to put new fancy stuff, like TimeSeries within their Redis Stack product. The python client for it is... wait for it... redis-py. i.e., what we already use. If we want a new version of Redis to solve CVEs or something, we just swap the image in the docker-compose files to that of the latest acceptable version of valkey. No problemo.

robertbartel commented 2 months ago

Thanks, @christophertubbs. This looks perfect. We'll go in this direction when we are ready (or are otherwise forced) to move off the current Redis image. I don't think anything compels us to do that ASAP, though I also won't argue if this gets done sooner rather than later.