Cleanup_after_CI_PR - Githubissues

NOAA-OWP / LGAR-C

Lumped Arid/Semi-arid Model (LASAM) simulates infiltration and surface runoff (two important components of the hydrologic cycle) based on Layered Green-Ampt with redistribution (LGAR) model

Other

1 stars 4 forks source link

Cleanup_after_CI_PR #16

Closed ajkhattak closed 10 months ago

ajkhattak commented 10 months ago

Merging realization files resulted after Git Actions workflow PR. Since LGAR-C comes with its own CMakeList file and will be added as a ngen submodule to adopting the style extern/Model/Model/cmake_build

Additions

none

Removals

merged files

Changes

none

Testing

Git Actions (only)

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Passes all existing automated tests
[x] Reviewers requested with the Reviewers tool :arrow_right:

stcui007 commented 10 months ago

Looks good to me. One minor suggestion, in ngen_integration.yaml:

      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
      - name: checkout actions in another repo
        uses: actions/checkout@v4
        with:
          repository: noaa-owp/soilfreezethaw

To be consistent with the rest of libraries, you migth want to change the comment line to "Checlout and build SoilFreezeThaw"

stcui007 commented 10 months ago

Another minor suggestion: You might want to the comment line to above the -name line.

      - name: Run Ngen Test with LASAM
        run: |
          # Run ngen with sft, smp, and lasam

ajkhattak commented 10 months ago

Changes incorporated. Thanks for reviewing @stcui007.