NOAA-OWP / LGAR-C

Lumped Arid/Semi-arid Model (LASAM) simulates infiltration and surface runoff (two important components of the hydrologic cycle) based on Layered Green-Ampt with redistribution (LGAR) model
Other
1 stars 3 forks source link

updating LASAM to take field capacity as a parameter in the config file #22

Closed peterlafollette closed 5 months ago

peterlafollette commented 5 months ago

[Short description explaining the high-level reason for the pull request]

Additions

In this PR, LASAM has been mildly refactored in order to have the field capacity be a user-specified parameter in the config file, in the same style as wilting point. I also updated the calibratable params list in bmi_lgar.hxx to include field capacity, as well as max ponded head. I also edited that list to not include vg_m and instead use vg_n, because the parameters file provides n rather than m.

Removals

-

Changes

-

Testing

1.

Screenshots

Notes

-

Todos

-

Checklist

Testing checklist

Target Environment support

Accessibility

Other

peterlafollette commented 5 months ago

Updated so that unit tests pass with n rather than m, will add max ponded depth and field capacity to unit test for calibration today / tomorrow

peterlafollette commented 5 months ago

Updated so that unit test checks calibration for all calibratable variables, including n, max ponded depth, and field capacity.