calibratable_parameters

NOAA-OWP / SoilMoistureProfiles

Computes 1D soil moisture profile for conceptual reservoirs (e.g., CFE) and layered-based reservoirs (e.g., LGAR)

5 stars 4 forks source link

calibratable_parameters #5

Closed ajkhattak closed 1 year ago

ajkhattak commented 1 year ago

The PR adds calibratable parameters smcmax ,b, and satpsi to bmi output variables list.

The code has been tested in/out of nextgen,
Tested in active (on) and inactive (off) calibratable mode
Existing tests have been updated
No changes to the functionality
Documentation (todo - as we plan to completely revise the Readme document of the repo)

peterlafollette commented 1 year ago

Tested standalone and unit test, everything passed. I notice that in test/main_unittest.cxx, there is the text: **** BEGIN SoilFreezeThaw BMI UNIT TEST *** . Aside from that I think it's ready.

ajkhattak commented 1 year ago

oh yeah, happens when you copy/paste things 😊. It should be SoilMoistureProfiles, good catch. I corrected it. Thanks.

peterlafollette commented 1 year ago

Looks good! :)