search

NOAA-OWP / SoilMoistureProfiles

Computes 1D soil moisture profile for conceptual reservoirs (e.g., CFE) and layered-based reservoirs (e.g., LGAR)
5 stars 4 forks source link

accept short and long form of soil_params #7

Closed aaraney closed 7 months ago

aaraney commented 10 months ago

Currently, several NOAA-OWP maintained BMI modules (see https://github.com/NOAA-OWP/SoilFreezeThaw/pull/14#issuecomment-1864879127) share the convention of using soil_params.<x> where x is a parameter name in their config file format. However, when soil_params parameters are exposed as calibratable, the convention is to drop soil_params and just use the parameter name. To avoid confusion and increase consistency, this change enables specifying soil_params in SoilMoistureProfile config files using just their name. Support for the existing soil_params names is maintained.

aaraney commented 7 months ago

@ajkhattak, can you give this a look when you get a chance?