Added a new scheme for the surface runoff that is based on Nash Cascade approach. The CFE will now support two schemes for surface runoff: 1) GIUH-based scheme, and 2) NASH_CASCADE-based scheme. Also, with these changes we will have now one Nash cascade model for the surface and one for the subsurface lateral flow. The two Nash models are slight different and hence implemented differently, but the hope is to merge them later. The changes in this PR don't change results of the existing tests.
Additions
Added Nash Cascade model for surface runoff
Removals
None
Changes
BMI variable name change GIUH_RUNOFF to SURFACE_RUNOFF
The model requires a new parameter surface_runoff_scheme as an input in the config file
Testing
All existing tests passed
Checklist
[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Reviewers requested with the Reviewers tool :arrow_right:
Added a new scheme for the surface runoff that is based on Nash Cascade approach. The CFE will now support two schemes for surface runoff: 1) GIUH-based scheme, and 2) NASH_CASCADE-based scheme. Also, with these changes we will have now one Nash cascade model for the surface and one for the subsurface lateral flow. The two Nash models are slight different and hence implemented differently, but the hope is to merge them later. The changes in this PR don't change results of the existing tests.
Additions
Removals
Changes
GIUH_RUNOFFtoSURFACE_RUNOFFsurface_runoff_schemeas an input in the config fileTesting
Checklist