search

NOAA-OWP / cfe

CFE is a conceptual rainfall-runoff model with an implementation of the Basic Model Interface.
Other
20 stars 21 forks source link

Should `nash_storage_subsurface` & `nash_storage_surface` be a 1d arrays of doubles? #124

Closed aaraney closed 2 weeks ago

aaraney commented 1 month ago

In the docs nash_storage_subsurface is listed as a double type, but in the parsing code, it looks like this should be a 1d array. @ajkhattak can you clarify this?

https://github.com/NOAA-OWP/cfe/blob/14f334a850981a564ee75b4181c2e9d4a74360b1/src/bmi_cfe.c#L1265

https://github.com/NOAA-OWP/cfe/blob/14f334a850981a564ee75b4181c2e9d4a74360b1/configs/README.md?plain=1#L25

aaraney commented 1 month ago

Looks like nash_storage_surface has the same issue.

ajkhattak commented 1 month ago

@aaraney you are right, they both should be 1D arrays, docs need to be updated...

aaraney commented 1 month ago

@ajkhattak, nash_storage_subsurface is optional too, right?

ajkhattak commented 3 weeks ago

@ajkhattak, nash_storage_subsurface is optional too, right?

that is correct. I will get this issue fixed today.