Update BMI spec to remove precipitation

[SnowHydrology]

Removals

• Removed atmosphere_water__liquid_equivalent_precipitation_rate from list of input_vars

Changes

• Changed the number of input_vars from 8 to 7
• Updated BMI functions accordingly

Testing

1. Ran PET code and unit tests

Todos

• Should we modify structs to remove all potential to read in/store precipitation data? Would be more intensive than just modifying the BMI specification.

Checklist

• [x] PR has an informative and human-readable title
• [x] Changes are limited to a single goal (no scope creep)
• [x] Code can be automatically merged (no conflicts)
• [x] Code follows project standards (link if applicable)
• [x] Passes all existing automated tests
• [x] Any change in functionality is tested
• [ ] New functions are documented (with a description, list of inputs, and expected output)
• [x] Placeholder code is flagged / future todos are captured in comments
• [ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
• [ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• [x] Reviewers requested with the Reviewers tool :arrow_right:

Target Environment support

• [ ] Linux
• [x] MacOS

[SnowHydrology]

@madMatchstick and @lcunha0118, I can convert this to draft if you think we should modify PET further as noted in the "Todos" above

Todos

Should we modify structs to remove all potential to read in/store precipitation data? Would be more intensive than just modifying the BMI specification.

[madMatchstick]

@madMatchstick and @lcunha0118, I can convert this to draft if you think we should modify PET further as noted in the "Todos" above

Todos Should we modify structs to remove all potential to read in/store precipitation data? Would be more intensive than just modifying the BMI specification.

Don't think removing aorc.precip_kg_per_m2 completely is really necessary here? If this is what you're asking. (But perhaps what is would be (re)moving AORC to separate repo/submodule, another topic... :) ).

Although, it wouldn't hurt to remove any get/set_value() or print statements within current build/run scripts; e.g. here and here

[SnowHydrology]

Although, it wouldn't hurt to remove any get/set_value() or print statements within current build/run scripts; e.g. here and here

That is a good catch. I can remove those. Did you run a comprehensive search or those were just two that stood out?

[SnowHydrology]

@madMatchstick I removed precip from get/set and from the print statements in both main programs. Unit tests and both main programs display expected behavior. I think this should be good for now unless you catch anything else. Thanks!

[madMatchstick]

Although, it wouldn't hurt to remove any get/set_value() or print statements within current build/run scripts; e.g. here and here

That is a good catch. I can remove those. Did you run a comprehensive search or those were just two that stood out?

These just stood out. I did confirm there are no others (excluding aorc_bmi, that is).