To fix the unrealistically large values from PET module options 2, 3 and 5:
Commenting out the zero-plane displacement height (d) function of the vegetation (canopy) height (hc) so to input the d value directly from the config file;
Modifying the momentum-transfer roughness length (zom) from the function of hc to a function of d and keeping the heat-transfer roughness length (zoh) function of zom to accommodate the magnitude logic among the three parameters d, zom and zoh;
Recompile PET module and rebuilt ngen.
Additions
In the config file, after the d value is set, the zom and zoh can be set as "0", and the functions in the code will pick up the d value to compute zom and zoh.
Removals
Commenting out the zero-plane displacement height function of the vegetation (canopy) height
//model->pet_params.zero_plane_displacement_height_m=2.0/3.0*model->pet_params.vegetation_height_m;
Changes
Modifying the momentum-transfer roughness length from the function of the vegetation height to a function of the zero-plane displacement height;
//model->pet_params.momentum_transfer_roughness_length_m=0.123*model->pet_params.vegetation_height_m;model->pet_params.momentum_transfer_roughness_length_m=0.1845*model->pet_params.zero_plane_displacement_height_m;
Testing
Start with d = 0.001
Screenshots
Notes
-
Todos
-
Checklist
[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:
To fix the unrealistically large values from PET module options 2, 3 and 5:
Additions
In the config file, after the d value is set, the zom and zoh can be set as "0", and the functions in the code will pick up the d value to compute zom and zoh.
Removals
//model->pet_params.zero_plane_displacement_height_m=2.0/3.0*model->pet_params.vegetation_height_m;Changes
//model->pet_params.momentum_transfer_roughness_length_m=0.123*model->pet_params.vegetation_height_m;model->pet_params.momentum_transfer_roughness_length_m=0.1845*model->pet_params.zero_plane_displacement_height_m;Testing
Screenshots
Notes
-
Todos
-
Checklist
Testing checklist
Target Environment support
Accessibility
Other