search

NOAA-OWP / evapotranspiration

Other
3 stars 9 forks source link

Create external submodule for aorc_bmi forcing code repo #17

Closed SnowHydrology closed 7 months ago

SnowHydrology commented 2 years ago

Current behavior

We currently house AORC forcing code in both the PET and CFE repos. This complicates maintenance and development as it needs to be performed twice.

Expected behavior

PET and CFE should each have an external submodule that points to the newly created aorc_bmi repo.

Steps to remedy behavior

  1. First complete and close issue 1 on aorc_bmi to have the forcing code and BMI wrapper housed within the new repo
  2. Fork the PET repo and start a new development branch
  3. Remove the /forcing_code directory from the main level of the branch
  4. Create a new /extern/forcing_code directory and subdirectory from the main level
  5. Add the aorc_bmi submodule: git submodule add https://github.com/NOAA-OWP/aorc_bmi.git extern/forcing_code
  6. Add a README to /extern
  7. Modify the build and run scripts as necessary in PET
  8. Test
  9. Commit changes, push, and submit PR
SnowHydrology commented 7 months ago

Closed by #19