Changing forcing_code to external submodule

[WanruWu-NOAA]

Changes to be committed: deleted: forcing_code/include/aorc.h deleted: forcing_code/include/aorc_tools.h deleted: forcing_code/include/bmi_aorc.h deleted: forcing_code/src/aorc.c deleted: forcing_code/src/bmi_aorc.c modified: make_and_run_pass_forcings.sh modified: src/main_pass_forcing.c

[Short description explaining the high-level reason for the pull request]

Additions

-

Removals

-

Changes

-

Testing

1.

Screenshots

Notes

-

Todos

-

Checklist

• [ ] PR has an informative and human-readable title
• [ ] Changes are limited to a single goal (no scope creep)
• [ ] Code can be automatically merged (no conflicts)
• [ ] Code follows project standards (link if applicable)
• [ ] Passes all existing automated tests
• [ ] Any change in functionality is tested
• [ ] New functions are documented (with a description, list of inputs, and expected output)
• [ ] Placeholder code is flagged / future todos are captured in comments
• [ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
• [ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• [ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist

Target Environment support

• [ ] Windows
• [ ] Linux
• [ ] Browser

Accessibility

• [ ] Keyboard friendly
• [ ] Screen reader friendly

Other

• [ ] Is useable without CSS
• [ ] Is useable without JS
• [ ] Flexible from small to large screens
• [ ] No linting errors or warnings
• [ ] JavaScript tests are passing

[SnowHydrology]

@WanruWu-NOAA I don't see the /extern directory here, nor an updated .gitmodules. Maybe you didn't push all of your commits. Can you also give your PRs and commits more illustrative titles and messages? This will allow us to better track changes over time. Also, please edit your top-level comment with the necessary info in the noted locations. Thanks!

[WanruWu-NOAA]

Thanks for the review, Keith. The /forcing_code/ was put incorrectly under ./ngen/extern/. I will close this PR and work on a new one.