search

NOAA-OWP / evapotranspiration

Other
3 stars 9 forks source link

time_step hard-coded to unit=seconds #24

Closed madMatchstick closed 7 months ago

madMatchstick commented 1 year ago

Based off get_time_step() def here, as well as any general search for time_step_size_s, seems like we are hard-coding an assumption for time step to be of units s.

Is this is case? If so, is this BMI compliant?

Reminder to further look into spec/implementation

SnowHydrology commented 1 year ago

My read is that this is okay because the model, when built, has the s built in regardless from the BMI spec and its internal time handling assumes the time step is in seconds.

peckhams commented 7 months ago

I agree that this is fine, because the model can choose its own timestep units as long as it is reported by the BMI function get_time_units(). That allows the framework to convert time units, if that were necessary.

On Fri, Mar 15, 2024 at 6:29 AM K. Jennings @.***> wrote:

Closed #24 https://github.com/NOAA-OWP/evapotranspiration/issues/24 as completed.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-OWP/evapotranspiration/issues/24#event-12130974673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2T4LZ44HRS44ORILLDPCLYYLSRJAVCNFSM6AAAAAA3EQWLGWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGEZTAOJXGQ3DOMY . You are receiving this because you were assigned.Message ID: @.***>