search

NOAA-OWP / evapotranspiration

Other
3 stars 9 forks source link

Unit test values in standalone script do not match #26

Closed madMatchstick closed 7 months ago

madMatchstick commented 1 year ago

One of the standalone scripts, ./make_and_run_read_forcings.sh, includes a Unit Test print out. Values do not match but expected values seem to be hard-coded? See pet.c here.

Reminder to look into this as potential bug or remove printout. 

aerodynamic method:
calculated instantaneous potential evapotranspiration (PET) =8.977490e-08 m/s

 #----------- BEGIN UNIT TESTS   ---------------# 

 #-----------       UNIT TEST    ---------------# 
solar elevation angle is 47.376995 degrees,
 and should be: 43.29101185 degrees 

 #-----------       UNIT TEST    ---------------# 
solar azimuth angle is 213.491150 degrees,
 and should be: 225.06371958 degrees 

 #-----------       UNIT TEST    ---------------# 
solar local hour angle is 21.942448 degrees,
 and should be: 31.01549773 degrees 

 #-----------       UNIT TEST    ---------------# 
potential ET is 8.977490e-08 m/s,
 and should be: 8.977490e-08 m/s 

 #------------  END UNIT TESTS   ---------------#