NOAA-OWP / evapotranspiration

Other
3 stars 9 forks source link

Unitialized pet_param member in BMI #27

Open hellkite500 opened 1 year ago

hellkite500 commented 1 year ago

A member of the pet_param struct, heat_transfer_roughness_length_m is NOT initialized in the BMI code. The related momentum_transfer_roughness_length_m is initialized in the BMI code, but BOTH of these parameters are used to determine (this condtional branch)[https://github.com/NOAA-OWP/evapotranspiration/blob/1df115fdd5376fe37be8ceafcb5df3b2dd0577e4/include/pet_tools.h#L408]. This value needs some initial value (0 based on the code in the pet_tools.h) before used in this function!