Closed aaraney closed 3 years ago
@aaraney Have you confirmed this change fixes the original google collab issue? Our other software devs may have an opinion on the general pattern, but nothing appears particularly obscene about this contribution to me.
@aaraney Have you confirmed this change fixes the original google collab issue? Our other software devs may have an opinion on the general pattern, but nothing appears particularly obscene about this contribution to me.
Yes. Here is a colab notebook that verifies this PR resolves the previous issue.
Thanks for the fix!
For sure!
This is a resubmission of #100 with minor changes to the unit test added. Fixes #99.
Changes
RestClient
is instantiated, try toimport nest_asyncio
and patch withnest_asyncio.apply()
. RaiseModuleNotFoundError
ifnest_asyncio
not installed.Testing
ModuleNotFoundError
is raised. Ifnest_asyncio
is installed, test fails.Checklist