NOAA-OWP / hydrotools

Suite of tools for retrieving USGS NWIS observations and evaluating National Water Model (NWM) data.
Other
54 stars 13 forks source link

Add Kling-Gupta Efficiency #172

Closed jarq6c closed 2 years ago

jarq6c commented 2 years ago

This PR adds the Kling-Gupta Efficiency hydrological model calibration/evaluation metric.

Gupta, H. V., Kling, H., Yilmaz, K. K., & Martinez, G. F. (2009). Decomposition of the mean squared error and NSE performance criteria: Implications for improving hydrological modelling. Journal of hydrology, 377(1-2), 80-91.

Additions

Removals

Changes

Testing

  1. Added test_kling_gupta_efficiency to test_metrics
  2. Added test_validation to check input validation methods

Notes

Todos

Checklist

jarq6c commented 2 years ago

Not only does it look good but it showed an error in some of my other code. And... approved.

Thanks for the review!