search

NOAA-OWP / hydrotools

Suite of tools for retrieving USGS NWIS observations and evaluating National Water Model (NWM) data.
Other
53 stars 12 forks source link

NWIS Client: Expose cache filename as option #175

Closed jarq6c closed 2 years ago

jarq6c commented 2 years ago

Allow users to set an alternative path for the cache when instantiating IVDataService.

Relevant line here: https://github.com/NOAA-OWP/hydrotools/blob/7294aac3cb65001c933b80fcc4a73bd5724f3765/python/nwis_client/src/hydrotools/nwis_client/iv.py#L89

aaraney commented 2 years ago

This is a pretty easy lift. Once #174 is merged, ill open a PR that adds this feature.

amaes3owp commented 2 years ago

Nice!

aaraney commented 2 years ago

@amaes3owp, see #176. Ill post a link to pypi once this PR has been merged in and i've published the new version to pypi.

amaes3owp commented 2 years ago

Thank you guys for getting this done so quickly!

aaraney commented 2 years ago

@amaes3owp, version 3.1.0 of hydrotools.nwis_client is now on pypi. Please upgrade to the latest version using:

pip install hydrotools.nwis-client==3.1.0
amaes3owp commented 2 years ago

Awesome!! Thank you for doing this upgrade

aaraney commented 2 years ago

Oh yeah of course! Thanks for opening up the ticket!

jarq6c commented 2 years ago

Thanks Austin!