NOAA-OWP / hydrotools

Suite of tools for retrieving USGS NWIS observations and evaluating National Water Model (NWM) data.
Other
53 stars 12 forks source link

Add `cache_filename` parameter to the NWIS Client constructor #176

Closed aaraney closed 2 years ago

aaraney commented 2 years ago

This PR adds cache_filename parameter to the NWIS Client. This allows a user to specify the location to store cached requests.

closes #175.

Additions

Changes

Testing

  1. Unit / integration tests for nwis_client now use temporary cache file. This results in test speeds that are slower, but it mitigates potentially strange behavior that might result from unit tests sharing a cache.

Notes

Checklist

amaes3owp commented 2 years ago

Nice! thank you @aaraney