NOAA-OWP / hydrotools

Suite of tools for retrieving USGS NWIS observations and evaluating National Water Model (NWM) data.
Other
53 stars 12 forks source link

Add `nwis_client` CLI #185

Closed jarq6c closed 2 years ago

jarq6c commented 2 years ago

This PR adds a minimal command-line interface to the nwis_client subpackage. The CLI entry point is called nwis-client. The nwis_client README includes examples of use. Currently the tool generates a CSV based on an arbitrary number of USGS site codes (see usage/help output in README). It includes three optional parameters: --startDT, --endDT, and --parameterCd. @aaraney

Additions

Removals

-

Changes

Testing

  1. Added minimal testing for CLI. Note: click includes test funtionality per CLIRunner, but this did not play well with asyncio, so I implemented similar functionality using subprocess.

Notes

Todos

-

Checklist

jarq6c commented 2 years ago

@aaraney I'm unable to add you as a reviewer until you comment. Any feedback you want to give?

aaraney commented 2 years ago

@jarq6c, thanks for pinging me. Id seen this, but had not had a chance to take a look. I certainly want to give you feedback / a review -- let me go ahead and do that now.

jarq6c commented 2 years ago

This has been published to PyPI.