Make map conversions more efficient alternative

jarq6c commented 2 years ago

This is an alternative to #188 . This PR removes the conversion step when checking contingency tables, resulting in much faster computations for categorical metrics.

Additions

None

Removals

convert_mapping_values

Changes

contingency tables are converted directly to pandas.Series of the appropriate type.

Testing

Removed test for convert_mapping_values

Notes

-

Todos

-

Checklist

[x] PR has an informative and human-readable title
[x] PR is well outlined and documented. See #12 for an example
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (see CONTRIBUTING.md)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
[ ] Placeholder code is flagged / future todos are captured in comments
[x] Reviewers requested with the Reviewers tool :arrow_right:

jarq6c commented 2 years ago

@groutr hopefully you don't mind reviewing this PR? :)

jarq6c commented 2 years ago

@aaraney any comments on this?

aaraney commented 2 years ago

@aaraney any comments on this?

Looks good! Thanks for tagging me!

jarq6c commented 2 years ago

These tests passed locally and also passed on GH prior to pip version 22.1. The tests on main will pass once #169 is merged in.

NOAA-OWP / hydrotools