[21pt] Create a tool for identifying catchment boundary issues

[CarsonPruitt-NOAA]

I'm open to suggestions on this tool, but my vision is for this new module to be able to produce inundation and a geopackage of catchment boundary issues given a flow file and a FIM directory. It should be structured similar to the interpolate_water_surface.py module where the catchment boundary function is inserted into the inundation process.

def find_catchment_boundary_issues(
    hydrofabric_dir,
    inundation_tif
):
    ## Your code to identify issues

def inundate_with_catchment_boundaries(
    hydrofabric_dir,
    hucs,
    flow_file,
    inundation_raster,
    output_fileNames=None,
    num_workers=1,
    keep_intermediate=False,
    log_file=None,
    verbose=False,
):
    print("Running Inundation")
    map_file = Inundate_gms(
        hydrofabric_dir=hydrofabric_dir,
        forecast=flow_file,
        num_workers=num_workers,
        hucs=hucs,
        inundation_raster=inundation_raster,
        verbose=verbose,
        log_file=log_file,
        output_fileNames=output_fileNames,
    )
    print("Mosaicking branches together")
    Mosaic_inundation(
        map_file,
        mosaic_attribute='depths_rasters',
        mosaic_output=depths_raster,
        mask=None,
        unit_attribute_name='huc8',
        nodata=elev_raster_ndv,
        workers=1,
        remove_inputs=not keep_intermediate,
        subset=None,
        verbose=verbose,
    )

    print("Determining locations for catchment boundary issues")
    find_catchment_boundary_issues(
        hydrofabric_dir=hydrofabric_dir,

    )

if __name__ == '__main__':
    ## This part should be mostly identical to the interpolate_water_surface.py module linked above
    ## with a few tweaks, like replace depth_raster with inundation_raster, etc.

[CarsonPruitt-NOAA]

Some hints to get your started on your function:

1. Convert the inundation raster to vector.
   • See this rasterio documentation for vectorization
2. Merge all of the catchment geopackages into one geodataframe.
3. Convert both the inundation polygon and merged catchment polygons to lines
   • I think the easiest way to do this would be the shapely.boundary method
4. Find where the inundation extent lines are coincident with any catchment boundary
   • My idea is to use shapely shared_paths

[RileyMcDermott-NOAA]

Here are some example outputs from the catchment boundary identification tool from HUC 17110010. With catchment boundary layer on:

How view would appear on waterview/FIM review:

[RileyMcDermott-NOAA]

Updated Catchment Boundary Example Maps: