search

NOAA-OWP / inundation-mapping

Flood inundation mapping and evaluation software configured to work with U.S. National Water Model.
Other
95 stars 30 forks source link

[3pt] Warning Cleanup: Burn in Bridges, Mask Levee-protected and D8 Slopes from DEM #1230

Open RobHanna-NOAA opened 4 months ago

RobHanna-NOAA commented 4 months ago

Now that we have a warning log file, it will uncover (and has) some warnings that maybe be addressed some day.

These ones came from a quick test against 05030104.

I selected just these three for now as they were very prevenent.

================

Burn in bridges 05030104 3821000006
/usr/local/lib/python3.10/dist-packages/rasterstats/io.py:335: NodataWarning: Setting nodata to -999; specify nodata explicitly
  warnings.warn(

Note: Some but not branches also threw a second part to the warning: ie)

Burn in bridges 05030104 3821000013
/usr/local/lib/python3.10/dist-packages/rasterstats/io.py:335: NodataWarning: Setting nodata to -999; specify nodata explicitly
  warnings.warn(
/usr/local/lib/python3.10/dist-packages/geopandas/io/file.py:633: UserWarning: You are attempting to write an empty DataFrame to file. For some drivers, this operation may fail.
  _to_file_fiona(df, filename, driver, schema, crs, mode, **kwargs)

In: delineate_hydros_and_produce_HAND.sh echo -e $startDiv"Burn in bridges $hucNumber $current_branch_id" python3 $srcDir/heal_bridges_osm.py \

================

Mask levee-protected areas from DEM (*Overwrite dem_meters.tif output) 05030104 3821000013
/usr/local/lib/python3.10/dist-packages/rasterio/mask.py:88: UserWarning: shapes are outside bounds of raster. Are they in different coordinate reference systems?
  warnings.warn('shapes are outside bounds of raster. '

in: delineate_hydros_and_produce_HAND.sh

================

D8 Slopes from DEM 05030104 3821000013
D8FlowDir version 5.3.5
WARNING: no output p file specified

In: delineate_hydros_and_produce_HAND.sh Yes. this is a Taudem call, but worth taking a peek at.

================

mluck commented 3 months ago

I ran fim_pipeline.sh on HUC 05030104 using dev-python-upgrades (#1253) and the first warnings have disappeared. The other two are still there.

-----------------------------------------------------------------
Burn in bridges 05030104 3821000006

-----------------------------------------------------------------

The UserWarning about an empty DataFrame was addressed by #1225.

-----------------------------------------------------------------
Burn in bridges 05030104 3821000013
The geoDataFrame is empty. File not saved.

-----------------------------------------------------------------