search

NOAA-OWP / inundation-mapping

Flood inundation mapping and evaluation software configured to work with U.S. National Water Model.
Other
92 stars 28 forks source link

[3pt] Hawaii points disappeared from stage-based CatFIM in release 4.5.2.11 #1279

Open EmilyDeardorff opened 1 week ago

EmilyDeardorff commented 1 week ago

The most recent version of stage-based CatFIM released with FIM version 4.5.2.11 has no mapped points in Hawaii. However, previous versions of CatFIM (such as 4.4.0.0) do have mapped points in Hawaii. Track down why these points are no longer being mapped.

EmilyDeardorff commented 1 week ago

I compared the CatFIM points for 4.4.0.0 and 4.5.2.11 and, for Hawaii, these are the LIDs that are present in the old version of CatFIM but not the new version: "olbh1" "hlah1" "wrvh1" "ksfh1" "mkhh1" "wkgh1" "pksh1" "hush1" "whsh1" "hnwh1" "hpoh1"

The status of these points in the old version is "ok" and their status in the new version (where they are not mapped) is "likely unacceptable gage datum error or accuracy code(s); please see acceptance criteria".

Apparently this code is used when an exception occurs, which is when LID is missing from the table (so the dem_adj_elevation value being missing from usgs_elev_table.csv).

As a check, LID ksfh1, which mapped correctly in the previous version but not this one, is not found in the usgs_elev_table.csv from the current version (/dev_fim_share/foss_fim/previous_fim/fim_4_4_0_0/20060000/) but is found in the usgs_elev_table.csv from FIM 4.5.2.11 (/dev_fim_share/foss_fim/previous_fim/fim_4_5_2_11/20060000/).

As an additional note, the usgs_elev_table.csv for HUC 20060000 in FIM version 4.4.0.0 is 74 rows long, whereas the table for HUC 20060000 for FIM version 4.5.2.11 is only 8 rows long... so I think there might have been an accidental removal of the sites from this table that resulted in them not being mapped in CatFIM.

image

image

usgs_elev_table.csv for FIM 4.4.0.0, HUC 20060000 (contains LID ksfh1) image

usgs_elev_table.csv for FIM 4.5.2.11, HUC 20060000 (does not contain LID ksfh1) image

EmilyDeardorff commented 1 week ago

For Hawaii sites of the usgs_gages.gpkg geopackage, the 'rating' column says 'no.' Would be good to check if there is a rating curve available for these sites in the WRDS API.

We have updated the gages and rating curves geopackage for the recent version, so we know they've changed since the last time CatFIM was run.

Only smaller changes have been done to the code that makes the usgs_elev_table.csv.

Also, it would be good to check in Ohio where there are also a lot of dropped sites!

EmilyDeardorff commented 1 week ago

The WRDS API entry for site ksfh1 does have a rating curve available.