NOAA-OWP / inundation-mapping

Flood inundation mapping and evaluation software configured to work with U.S. National Water Model.
Other
95 stars 30 forks source link

[5pt] Modify feature_id attribute extraction for usgs_gage_crosswalk.py #498

Closed RyanSpies-NOAA closed 2 years ago

RyanSpies-NOAA commented 2 years ago

usgs_gage_crosswalk.py currently crosswalks USGS gage points to the hydrofabric "feature_id" using a spatial join with the hydroid catchment polygon layer. This can result in attributing the wrong feature_id when the gage point resides near the boundary of hydroids. Suggest using the USGS gage snapped to the channel/thalweg before performing the sjoin to help avoid this issue.

CarsonPruitt-NOAA commented 2 years ago

The feature_id mismatch has been traced back to an out-of-date AHPS site dataset. Catchments that have AHPS sites will use its attribute table in the crosswalk and will produce erroneous HydroID -- feature_id pairs, which will be passed into the hydroTable.csv output.