search

NOAA-OWP / lstm

Other
12 stars 17 forks source link

Config file path should be type string #29

Closed madMatchstick closed 1 year ago

madMatchstick commented 2 years ago

See bmi.initialize() definition,

def initialize( self, bmi_cfg_file=None ):
    #NJF ensure this is a Path type so the follow open works as expected
    #When used with NGen, the bmi_cfg_file is just a string...
    bmi_cfg_file = Path(bmi_cfg_file)

Per #NJF comment, we should maintain bmi_config_file as a string for ngen compliance.

Current behavior

bmi_config_file is of type path

Expected behavior

bmi_config_file is of type string

madMatchstick commented 1 year ago

adjusted in PR #34 . closing