search

NOAA-OWP / lstm

Other
12 stars 17 forks source link

Fix getter and setter BMI functions #30

Closed robertbartel closed 2 years ago

robertbartel commented 2 years ago

Proposed solution for #24.

madMatchstick commented 2 years ago

I don't see any issues with this. Thanks @robertbartel for these corrections.

Note that the main adjustment is correcting the get_value() definition to match the BMI v2.0 specification as outlined in the issue #24 thread.

I will need update the jupyter notebooks prior to merging. -thanks!