NOAA-OWP / ngen-cal

Tools for calibrating and configuring NextGen
https://github.com/NOAA-OWP/ngen-cal/wiki
Other
8 stars 15 forks source link

Deprecate and rename `hook_objects` to `hook_factories` #191

Open aaraney opened 1 week ago

aaraney commented 1 week ago

https://github.com/NOAA-OWP/ngen-cal/blob/026086870732e740691af87bcaddef112f03679d/python/ngen_config_gen/src/ngen/config_gen/generate.py#L37

Add deprecation warning if hook_objects is used.

I think it’s worth easing future pain by modifying the api to be keyword only too. To my knowledge all uses of this function specify arguments as keywords. I’ll do more investigating before making this breaking change.