Combination of fixes and improvements to work with ngen. These changes allow the generated files to be used with the current version of ngen.
Additions
Explicit chunking and compression to data variables
Removals
Changes
weighted_sum and weighted_mean stats changed to sum and mean
Fixes all ids values being truncated to one character
Changed the way time units are stored--the previous way is actually what is recommended by Unidata, so this may be changed back, but this is what ngen currently supports.
Time is set to an unlimited dimension
Time values are now a series per catchment--varying time values per catchment are not yet supported but we wanted to structure the file format to possibly support it in the future.
Testing
Used this version of the script to generate a HUC01 forcing data file from the new 09/2022 hydrofabric, and ran it in ngen.
Screenshots
Notes
-
Todos
Review time units change--this should probably change in ngen.
Checklist
[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows project standards (link if applicable)
[X] Passes all existing automated tests
[X] Any change in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[X] Placeholder code is flagged / future todos are captured in comments
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[X] Reviewers requested with the Reviewers tool :arrow_right:
Combination of fixes and improvements to work with ngen. These changes allow the generated files to be used with the current version of ngen.
Additions
Removals
Changes
weighted_sum
andweighted_mean
stats changed tosum
andmean
ids
values being truncated to one characterTime
is set to an unlimited dimensionTime
values are now a series per catchment--varying time values per catchment are not yet supported but we wanted to structure the file format to possibly support it in the future.Testing
Screenshots
Notes
-
Todos
Checklist
Testing checklist
Target Environment support