issues
search
NOAA-OWP
/
ngen
Next Generation Water Modeling Engine and Framework Prototype
Other
84
stars
63
forks
source link
Update PET and Topmodel to get bug, sanitizer/valgrind, and -Werror fixes
#785
Closed
PhilMiller
closed
7 months ago
PhilMiller
commented
7 months ago
Changes
Update PET, particularly to get NOAA-OWP/evapotranspiration#35
Update Topmodel, particularly to get NOAA-OWP/topmodel#46 and NOAA-OWP/topmodel#47
Fixes #776
Testing
Github CI
Checklist
[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any
change
in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the
Reviewers tool
:arrow_right:
Target Environment support
[x] Linux
[x] macOS
Changes
Fixes #776
Testing
Checklist
Target Environment support