NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype
Other
84 stars 63 forks source link

Update CFE, PET, and Topmodel again for -Werror fixes #786

Closed PhilMiller closed 7 months ago

PhilMiller commented 7 months ago

More module revisions in support of #781

Changes

Testing

  1. CI

Checklist

Target Environment support

PhilMiller commented 7 months ago

Looks like a small update to CFE is also needed:

[  5%] Building C object /home/runner/work/ngen/ngen/extern/cfe/cmake_build/CMakeFiles/cfebmi.dir/cfe/src/bmi_cfe.c.o
/home/runner/work/ngen/ngen/extern/cfe/cfe/src/bmi_cfe.c: In function ‘read_init_config_cfe’:
/home/runner/work/ngen/ngen/extern/cfe/cfe/src/bmi_cfe.c:513:9: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
  513 |         fgets(config_line, max_config_line_length + 1, fp);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/ngen/ngen/extern/cfe/cfe/src/bmi_cfe.c: In function ‘Initialize’:
/home/runner/work/ngen/ngen/extern/cfe/cfe/src/bmi_cfe.c:1252:9: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
 1252 |         fgets(line_str, max_forcing_line_length + 1, ffp);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/ngen/ngen/extern/cfe/cfe/src/bmi_cfe.c:1257:13: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
 1257 |             fgets(line_str, max_forcing_line_length + 1, ffp);  // read in a line of AORC data.
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~