issues
search
NOAA-OWP
/
ngen
Next Generation Water Modeling Engine and Framework Prototype
Other
84
stars
63
forks
source link
Resolve several minor bugs
#791
Closed
program--
closed
7 months ago
program--
commented
7 months ago
Resolves #782.
Resolves #783.
Resolves #784.
Changes
Removes default
link_key
value for network class constructor.
Replaces a bitwise AND with logical AND in the geopackage read function.
Replaces usage of VLAs with
std::vector
in parallel_utils.h.
Checklist
[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[X] Any
change
in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[X] Placeholder code is flagged / future todos are captured in comments
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the
Reviewers tool
:arrow_right:
Changes
link_keyvalue for network class constructor.std::vectorin parallel_utils.h.Checklist