Closed PhilMiller closed 2 months ago
If we merge this, then the actual ngen
code and its tests compiles with -Werror -Wall -Wno-reorder -Wno-unused -Wno-sign-compare
on GCC 13. The others are less definitively problematic.
The selection of flags added to CI is based on which ones are available for both GCC and AppleClang. Otherwise, the build just fails with unrecognized command line arguments.
Changes
-Wpessimizing-move
reported by either GCC or AppleClang|
instead of logical||
vector<string>
working on values rather than references-Wmaybe-uninitialized
by setting output-argument pointer variables tonullptr
boost::bad_get
by valueTesting
Notes
This gets us a large portion of the way to being able to build with
-Wall
for C++-Wsign-compare
)-Wnon-virtual-dtor
)Checklist