NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype
Other
82 stars 57 forks source link

Drop fatal error else case when trying to update submodules #802

Closed hellkite500 closed 2 months ago

hellkite500 commented 2 months ago

The error condition this was originally trapping doesn't seem relevant, and results in a fatal build error when the submodule build option is disabled, even thought it shouldn't be.

Changes

Checklist

Testing checklist

  1. Build tested locally

Target Environment support

PhilMiller commented 2 months ago

The change looks good to me, but I'm a bit confused about the code that's being removed. The error message seems incongruous with the logic