Open PhilMiller opened 2 months ago
https://github.com/NOAA-OWP/ngen/blob/dd664668975e84a21d58c79300248210a0a256bf/include/forcing/DataProvider.hpp#L87
The member function signature in the DataProvider interface demands the allocation of a temporary vector and the likely copying of data from that temporary vector by the consumer.
DataProvider
vector
The signature ought to be
virtual void get_values(boost::span<data_type> output, selection_type const& selector, ReSampleMethod = SUM);
We could phase the refactoring by
get_values
DataProvider::get_values
https://github.com/NOAA-OWP/ngen/blob/dd664668975e84a21d58c79300248210a0a256bf/include/forcing/DataProvider.hpp#L87
The member function signature in the
DataProvider
interface demands the allocation of a temporaryvector
and the likely copying of data from that temporary vector by the consumer.The signature ought to be
We could phase the refactoring by
get_values
and copies the dataDataProvider
implementationsDataProvider::get_values
callers