issues
search
NOAA-OWP
/
ngen
Next Generation Water Modeling Engine and Framework Prototype
Other
82
stars
57
forks
source link
#737: Initial draft of SCHISM Coastal Formulation
#810
Open
PhilMiller
opened
2 months ago
PhilMiller
commented
2 months ago
Resolves #737
Additions
CoastalFormulation
abstract base class
Support classes for relevant
DataProvider
instantiations that
CoastalFormulation
will need
SCHISM-based implementation of
CoastalFormulation
Removals
-
Changes
-
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
[x] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any
change
in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the
Reviewers tool
:arrow_right:
Testing checklist (automated report can be put here)
1.
Target Environment support
[ ] Linux
Resolves #737
Additions
CoastalFormulation
abstract base classDataProvider
instantiations thatCoastalFormulation
will needCoastalFormulation
Removals
-
Changes
-
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
Testing checklist (automated report can be put here)
1.
Target Environment support