Build System not finding system versions of pybind installed by conda

NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype

Other

82 stars 57 forks source link

Build System not finding system versions of pybind installed by conda #811

Open donaldwj opened 2 months ago

donaldwj commented 2 months ago

Short description explaining the high-level reason for the new issue.

Current behavior

The ngen build system is installing its own copy of pybind when there is a system install used.

Expected behavior

The build system should use the system pybind install unless it is out of date.

Steps to replicate behavior (include URLs)

Screenshots

program-- commented 2 months ago

As a note: this is expected behavior (currently) and doesn't have to do with conda. We intentionally use the vendored version of pybind11 (line 275): https://github.com/NOAA-OWP/ngen/blob/dd664668975e84a21d58c79300248210a0a256bf/CMakeLists.txt#L271-L276

The easiest change/fix for this is probably replacing line 275 with a find_package(pybind11 CONFIG) call, and conditionally calling add_subdirectory if pybind11_FOUND is false.