NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype
Other
82 stars 57 forks source link

Update internal use of old macros #813

Closed PhilMiller closed 1 month ago

PhilMiller commented 2 months ago

We introduced a consistent set of NGEN_WITH_FOO macros, and started using them. We should go through and replace uses of the old, inconsistent ones.

PhilMiller commented 2 months ago

Editing the listed output below to reflect changes already made

$ git grep -o -h -E '[A-Z_]*_ACTIVE' | sort | uniq

I'll leave these alone, since they're all set specifically inside test/CMakeLists.txt

Plus some others, e.g.

PhilMiller commented 1 month ago

~I'm going to create a separate issue for ACTIVATE_PYTHON, and call the present PR done. There's a lot more instances of that one, and I'm about done for the day.~

I'm just finishing this.